Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4722: Created date not fully visible for certain devices and languages #4755

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Fix #4722: Created date not fully visible for certain devices and languages #4755

merged 5 commits into from
Jan 11, 2023

Conversation

antonmagnus
Copy link
Contributor

@antonmagnus antonmagnus commented Nov 22, 2022 •
edited
Loading

Explanation

Fixes issue #4772

This PR adds some margin to the end of the created date text on the edit profile view to make sure that it's fully visible.

The main development was done on a pixel 3a on API 29 (see the screenshots below). However, since the issue was reported on a Infinix SMART 5 the changes have also been tested on a device with a similar screen resolution (Galaxy Nexus on API 29).

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Previous version

oppia_old_version_port

New version

oppia_port

oppia_port_land

oppia_eng

oppia_arabic

ProfileEditFragmentTest

Screenshot 2022-11-23 at 10 29 42

@antonmagnus antonmagnus requested a review from rt4914 as a code owner November 22, 2022 14:35
@BenHenning
Copy link
Member

BenHenning commented Nov 23, 2022 •
edited
Loading

@antonmagnus could you please update the PR description to match the PR template, and make sure that each section is filled out?

@antonmagnus
Copy link
Contributor Author

@antonmagnus could you please update the PR description to match the PR template, and make sure that each section is filled out?

Updated and included the template checklist.

@BenHenning
Copy link
Member

Thanks @antonmagnus. Can you make sure that the explanation portion is in the 'Explanation' section, and that the screenshots are in the 'For UI-specific PRs only' section?

See #4685 for an example PR description.

@oppiabot
Copy link

oppiabot bot commented Nov 30, 2022

Hi @antonmagnus, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 30, 2022
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 1, 2022
@antonmagnus
Copy link
Contributor Author

Thanks @antonmagnus. Can you make sure that the explanation portion is in the 'Explanation' section, and that the screenshots are in the 'For UI-specific PRs only' section?

See #4685 for an example PR description.

I have now updated the description in accordance with the template. Do you have any further suggestions?

@BenHenning
Copy link
Member

Thanks @antonmagnus. Can you make sure that the explanation portion is in the 'Explanation' section, and that the screenshots are in the 'For UI-specific PRs only' section?
See #4685 for an example PR description.

I have now updated the description in accordance with the template. Do you have any further suggestions?

I think it's much better, but I suggest a few small changes to help with readability (& to ensure GitHub correctly closes the corresponding issue once this is closed):

Fixes issue #4772

This PR adds some margin to the end of the created date text on edit profile view to make sure that it's fully visible.

The main development was done on a pixel 3a on API 29 (see the screenshots below). However, since the issue was reported on a Infinix SMART 5 the changes have also been tested on a device with similar screen resolution (Galaxy Nexus on API 29).

Notice how I formatted the 'fixes' part, and also re-worded the explanation to read more as "Did X to fix Y" to be really clear on what the PR is doing.

@antonmagnus
Copy link
Contributor Author

Thanks @antonmagnus. Can you make sure that the explanation portion is in the 'Explanation' section, and that the screenshots are in the 'For UI-specific PRs only' section?
See #4685 for an example PR description.

I have now updated the description in accordance with the template. Do you have any further suggestions?

I think it's much better, but I suggest a few small changes to help with readability (& to ensure GitHub correctly closes the corresponding issue once this is closed):

Fixes issue #4772

This PR adds some margin to the end of the created date text on edit profile view to make sure that it's fully visible.

The main development was done on a pixel 3a on API 29 (see the screenshots below). However, since the issue was reported on a Infinix SMART 5 the changes have also been tested on a device with similar screen resolution (Galaxy Nexus on API 29).

Notice how I formatted the 'fixes' part, and also re-worded the explanation to read more as "Did X to fix Y" to be really clear on what the PR is doing.

Thank you for the suggestions, I agree that it is clearer now.
I have updated the description based on your suggestions.

@BenHenning
Copy link
Member

Thanks @antonmagnus. Note that, when you're done addressing a reviewer's comments, you should let them know by saying 'PTAL @' so that they are aware that they need to take another review pass.

@rt4914 PTAL for codeowners.

@BenHenning BenHenning assigned rt4914 and unassigned antonmagnus Dec 6, 2022
rt4914
rt4914 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @antonmagnus

@rt4914 rt4914 assigned antonmagnus and unassigned rt4914 Dec 6, 2022
@oppiabot oppiabot bot added the PR: LGTM label Dec 6, 2022
@oppiabot
Copy link

oppiabot bot commented Dec 13, 2022

Hi @antonmagnus, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 13, 2022
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 14, 2022
@oppiabot
Copy link

oppiabot bot commented Dec 21, 2022

Hi @antonmagnus, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 21, 2022
@oppiabot oppiabot bot closed this Dec 28, 2022
@BenHenning BenHenning reopened this Jan 10, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 10, 2023
@BenHenning
Copy link
Member

Resolving the conflict & marking this PR for auto-merge since it's been approved.

@BenHenning BenHenning enabled auto-merge (squash) January 10, 2023 01:52
@BenHenning BenHenning merged commit 2c3784e into oppia:develop Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@antonmagnus antonmagnus

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonmagnus @BenHenning @rt4914